Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in mean_ap by 11 points #4875

Merged
merged 1 commit into from Apr 6, 2021
Merged

Conversation

ZephyrusKylin
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #4875 (467202a) into master (5af5063) will increase coverage by 1.08%.
The diff coverage is 89.40%.

❗ Current head 467202a differs from pull request most recent head d88ca23. Consider uploading reports for the commit d88ca23 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4875      +/-   ##
==========================================
+ Coverage   64.33%   65.41%   +1.08%     
==========================================
  Files         252      255       +3     
  Lines       19860    19981     +121     
  Branches     3383     3398      +15     
==========================================
+ Hits        12776    13070     +294     
+ Misses       6405     6212     -193     
- Partials      679      699      +20     
Flag Coverage Δ
unittests 65.38% <89.40%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/assigners/atss_assigner.py 93.50% <ø> (+77.92%) ⬆️
mmdet/core/bbox/assigners/base_assigner.py 100.00% <ø> (+20.00%) ⬆️
mmdet/core/bbox/assigners/hungarian_assigner.py 88.37% <ø> (ø)
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <ø> (ø)
mmdet/core/bbox/coder/base_bbox_coder.py 100.00% <ø> (+20.00%) ⬆️
mmdet/core/bbox/coder/bucketing_bbox_coder.py 63.76% <ø> (ø)
...mdet/core/bbox/iou_calculators/iou2d_calculator.py 96.77% <ø> (ø)
mmdet/core/bbox/match_costs/match_cost.py 93.61% <ø> (ø)
mmdet/core/evaluation/class_names.py 36.00% <ø> (ø)
mmdet/core/evaluation/mean_ap.py 41.63% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af5063...d88ca23. Read the comment docs.

@ZwwWayne ZwwWayne requested a review from hhaAndroid April 1, 2021 08:09
@ZwwWayne ZwwWayne merged commit a56638f into open-mmlab:master Apr 6, 2021
ZwwWayne pushed a commit that referenced this pull request Apr 6, 2021
@OpenMMLab-Assistant-007
Copy link

Hi!
@ZephyrusKylin
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants