Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix voc recall iou_thr name error #5195

Merged
merged 1 commit into from
May 23, 2021

Conversation

hhaAndroid
Copy link
Collaborator

Motivation

Variable name typo error in RPN recall evaluation code on VOC dataset.

resolve: #5186

Modification

replace iou_thr with iou_thrs.

@hhaAndroid hhaAndroid requested a review from ZwwWayne May 21, 2021 03:35
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #5195 (76c0019) into master (e8b9dc7) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5195      +/-   ##
==========================================
+ Coverage   65.17%   65.20%   +0.02%     
==========================================
  Files         269      272       +3     
  Lines       20844    21078     +234     
  Branches     3500     3531      +31     
==========================================
+ Hits        13586    13743     +157     
- Misses       6492     6567      +75     
- Partials      766      768       +2     
Flag Coverage Δ
unittests 65.16% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/voc.py 29.16% <0.00%> (ø)
mmdet/core/utils/misc.py 74.28% <0.00%> (-25.72%) ⬇️
mmdet/models/utils/gaussian_target.py 93.93% <0.00%> (-6.07%) ⬇️
mmdet/models/dense_heads/corner_head.py 69.62% <0.00%> (-1.12%) ⬇️
mmdet/models/necks/__init__.py 100.00% <0.00%> (ø)
mmdet/models/detectors/__init__.py 100.00% <0.00%> (ø)
mmdet/models/dense_heads/__init__.py 100.00% <0.00%> (ø)
mmdet/models/dense_heads/centernet_head.py 83.33% <0.00%> (ø)
mmdet/models/necks/ct_resnet_neck.py 65.21% <0.00%> (ø)
mmdet/models/detectors/centernet.py 26.82% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b9dc7...76c0019. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 6cdcdc7 into open-mmlab:master May 23, 2021
@hhaAndroid hhaAndroid deleted the fix_voc_iou_thrs branch March 19, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable name typo error in RPN recall evaluation code on VOC dataset
2 participants