Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance]: Check dtype in transform unit tests. #5969

Merged
merged 4 commits into from Sep 7, 2021

Conversation

RangiLyu
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add data type check in transform unit test.

Modification

  • Move some common functions into utils.py and add data type check.
  • Assert dtype of box is float32.

BC-breaking (Optional)

None.

@ZwwWayne ZwwWayne merged commit f05f843 into open-mmlab:master Sep 7, 2021
@RangiLyu RangiLyu deleted the fix/fix_test_transform branch January 13, 2022 08:18
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* add dtype to bbox unit test

* add dtype to unit test

* add docstring

* add label and check dtype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants