Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch symlink failure on Windows #6482

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Catch symlink failure on Windows #6482

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8dae8c7
Catch symlink failure on Windows
del-zhenwu Nov 11, 2021
7a2887c
Set copy mode on Windows
del-zhenwu Nov 11, 2021
2d6c067
Fix lint
del-zhenwu Nov 11, 2021
8dca5f8
Fix logic error
del-zhenwu Nov 15, 2021
7210c39
Merge branch 'master' of https://github.com/open-mmlab/mmdetection in…
del-zhenwu Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Copyright (c) OpenMMLab. All rights reserved.
import os
import os.path as osp
import platform
import shutil
import sys
import warnings
Expand Down Expand Up @@ -141,7 +142,11 @@ def add_mim_extension():
# parse installment mode
if 'develop' in sys.argv:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic should be:

if 'develop' in sys.argv :
  if platform.system() == 'Windows': 
      mode='copy'
  else:
     mode='sylink'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a fix

# installed by `pip install -e .`
mode = 'symlink'
if platform.system() == 'Windows':
# set `copy` mode here since symlink fails on Windows.
mode = 'copy'
else:
mode = 'symlink'
elif 'sdist' in sys.argv or 'bdist_wheel' in sys.argv:
# installed by `pip install .`
# or create source distribution by `python setup.py sdist`
Expand Down