Add loss evaluator #678
Merged
Add loss evaluator #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellock
reviewed
May 21, 2019
mmdet/models/bbox_heads/bbox_head.py
Outdated
| @@ -2,8 +2,8 @@ | |||
| import torch.nn as nn | |||
| import torch.nn.functional as F | |||
|
|
|||
| from mmdet.core import (delta2bbox, multiclass_nms, bbox_target, | |||
| weighted_cross_entropy, weighted_smoothl1, accuracy) | |||
| from mmdet.core import (delta2bbox, multiclass_nms, bbox_target, accuracy) | |||
There was a problem hiding this comment.
The brackets are unnecessary in a single line.
| @@ -63,7 +63,7 @@ def __init__(self, | |||
| # add reg specific branch | |||
| self.reg_convs, self.reg_fcs, self.reg_last_dim = \ | |||
| self._add_conv_fc_branch( | |||
| self.num_reg_convs, self.num_reg_fcs, self.shared_out_channels) | |||
| self.num_reg_convs, self.num_reg_fcs, self.shared_out_channels) | |||
mmdet/models/losses/focal_loss.py
Outdated
|
|
||
|
|
||
| @LOSSES.register_module | ||
| class FocalLoss(CrossEntropyLoss): |
There was a problem hiding this comment.
FocalLoss may directly inherit from nn.Module.
mmdet/models/losses/focal_loss.py
Outdated
| *args, | ||
| **kwargs) | ||
| else: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
NotImplementedError does not need the parenthesis.
hellock
approved these changes
May 21, 2019
Closed
JegernOUTT
pushed a commit
to JegernOUTT/mmdetection
that referenced
this pull request
Nov 23, 2019
* Fix license in setup.py * Add code for loss evaluator * Configs support loss evaluator * Fix a little bug * Fix flake8 * return revised bbox to reg * return revised bbox to reg * revision according to comments * fix flake8
FANGAreNotGnu
pushed a commit
to FANGAreNotGnu/mmdetection
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.