Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Support respliting data_batch with tag #7641

Merged
merged 6 commits into from Apr 21, 2022

Conversation

Czm369
Copy link
Collaborator

@Czm369 Czm369 commented Apr 6, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support respliting data_batch with tag.

Modification

Add a function in mmdet/utils/data_batch.py which can respliting data_batch with tag, such as 'sup', 'unsup_teacher', and 'unsup_student'.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #7641 (be2ab02) into dev (c8270c3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #7641      +/-   ##
==========================================
+ Coverage   64.92%   64.94%   +0.02%     
==========================================
  Files         348      349       +1     
  Lines       28323    28338      +15     
  Branches     4778     4783       +5     
==========================================
+ Hits        18389    18405      +16     
  Misses       8957     8957              
+ Partials      977      976       -1     
Flag Coverage Δ
unittests 64.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/utils/__init__.py 100.00% <100.00%> (ø)
mmdet/utils/split_batch.py 100.00% <100.00%> (ø)
mmdet/core/bbox/assigners/max_iou_assigner.py 73.68% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8270c3...be2ab02. Read the comment docs.

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmdet/utils/batch_resplit.py Outdated Show resolved Hide resolved
mmdet/utils/batch_resplit.py Outdated Show resolved Hide resolved
mmdet/utils/batch_resplit.py Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

Should resolve conflict

Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit c6f467f into open-mmlab:dev Apr 21, 2022
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
* support respliting data_batch with tag

* add citations

* add a unit test

* fix lint
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* support respliting data_batch with tag

* add citations

* add a unit test

* fix lint
@Czm369 Czm369 deleted the batch_resplit branch August 20, 2022 12:36
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* support respliting data_batch with tag

* add citations

* add a unit test

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants