-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Support reading gpu_collect
from cfg.evaluation.gpu_collect
#7672
Conversation
tools/test.py
Outdated
args.gpu_collect) | ||
outputs = multi_gpu_test( | ||
model, data_loader, args.tmpdir, args.gpu_collect | ||
or cfg.evaluation.gpu_collect) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the cfg.evaluation.gpu_collect is not set? Will it cause error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will. I'll fix it soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use args.gpu_collect or cfg.evaluation.get('gpu_collect', False)
here.
gpu_collect
from cfg.evaluation.gpu_collect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ct (#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
…ct (open-mmlab#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
…ct (open-mmlab#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
Motivation
During testing, the
cfg.evaluation.gpu_collect
does not take effect. Rather, users need to specifygpu_collect
from the command line.This behavior is inconsistent with the evaluation during training, where
cfg.evaluation.gpu_collect
decides whether to usegpu_collect
.Modification
gpu_collect = args.gpu_collect or cfg.evaluation.gpu_collect
intools/test.py
line 238-239Checklist
Reference
Issue #7495