[Enhance] Support reading gpu_collect from cfg.evaluation.gpu_collect
#7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZwwWayne
reviewed
Apr 11, 2022
tools/test.py
Outdated
| args.gpu_collect) | ||
| outputs = multi_gpu_test( | ||
| model, data_loader, args.tmpdir, args.gpu_collect | ||
| or cfg.evaluation.gpu_collect) |
There was a problem hiding this comment.
what if the cfg.evaluation.gpu_collect is not set? Will it cause error？
There was a problem hiding this comment.
Yes, it will. I'll fix it soon
There was a problem hiding this comment.
We can use args.gpu_collect or cfg.evaluation.get('gpu_collect', False) here.
jbwang1997
changed the title
gpu_collect from cfg.evaluation.gpu_collect
ZwwWayne
pushed a commit
that referenced
this pull request
Jul 18, 2022
…ct (#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 19, 2022
…ct (open-mmlab#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
SakiRinn
pushed a commit
to SakiRinn/mmdetection-locount
that referenced
this pull request
Mar 17, 2023
…ct (open-mmlab#7672) * feat: read from cfg.evaluation.gpu_collect * chore: yapf * fix: gpu_collect not in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During testing, the
cfg.evaluation.gpu_collectdoes not take effect. Rather, users need to specifygpu_collectfrom the command line.This behavior is inconsistent with the evaluation during training, where
cfg.evaluation.gpu_collectdecides whether to usegpu_collect.Modification
gpu_collect = args.gpu_collect or cfg.evaluation.gpu_collectintools/test.pyline 238-239Checklist
Reference
Issue #7495