Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixtypo:name of default act func is wrong #7794

Merged
merged 1 commit into from
May 8, 2022

Conversation

DarthThomas
Copy link
Contributor

Motivation

Found a small typo in docstring

Modification

corrected a small typo in docstring

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2022

CLA assistant check
All committers have signed the CLA.

@chhluo chhluo changed the base branch from master to dev April 23, 2022 07:26
Copy link
Collaborator

@chhluo chhluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #7794 (111b440) into dev (6b87ac2) will increase coverage by 0.66%.
The diff coverage is 81.78%.

@@            Coverage Diff             @@
##              dev    #7794      +/-   ##
==========================================
+ Coverage   63.41%   64.08%   +0.66%     
==========================================
  Files         340      346       +6     
  Lines       27493    28117     +624     
  Branches     4645     4744      +99     
==========================================
+ Hits        17436    18019     +583     
- Misses       9131     9152      +21     
- Partials      926      946      +20     
Flag Coverage Δ
unittests 64.06% <81.78%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/test.py 12.50% <0.00%> (-0.90%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <ø> (ø)
mmdet/core/post_processing/bbox_nms.py 79.10% <ø> (ø)
mmdet/core/utils/__init__.py 100.00% <ø> (ø)
mmdet/datasets/pipelines/instaboost.py 15.00% <0.00%> (ø)
mmdet/models/backbones/swin.py 81.50% <ø> (ø)
...mdet/models/dense_heads/free_anchor_retina_head.py 16.00% <0.00%> (-0.22%) ⬇️
mmdet/models/dense_heads/ssd_head.py 85.84% <ø> (ø)
mmdet/models/necks/fpn.py 94.66% <ø> (ø)
mmdet/core/utils/dist_utils.py 23.59% <15.38%> (-1.41%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b87ac2...111b440. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 2a643e4 into open-mmlab:dev May 8, 2022
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
@OpenMMLab-Assistant-004
Copy link

Hi @DarthThomas !First of all, we want to express our gratitude for your significant PR in the mmdetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants