Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename panoptic seg related and Realse instance seg related for Mask2Former #8032

Merged
merged 11 commits into from
May 27, 2022

Conversation

chhluo
Copy link
Collaborator

@chhluo chhluo commented May 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Rename configs for panoptic segmentation.
  2. Release configs, logs and checkpoints for instance segmentation. For instance segmentation, We have trained the models for many times with the algorithm we implemented (see PR 7571), and the performance of the trained models is relatively stable (+- 0.2), and there is a certain gap between the performance of the models we trained and the results mentioned in the paper. However, the performance of the model trained with the official code are unstable, and the performance may be lower than the target results (see issue).
  3. fix bug in gather_models.py

Modification

  1. Rename configs for panoptic segmentation: mask2former_xxx_coco.py -> mask2former_xxx_coco-panoptic.py. mask2former_xxx_coco.py is for instance segmentation, while mask2former_xxx_coco-panoptic.py for panoptic segmentation.

BC-breaking (Optional)

Rename configs for panoptic segmentation: mask2former_xxx_coco.py -> mask2former_xxx_coco-panoptic.py. mask2former_xxx_coco.py is for instance segmentation, while mask2former_xxx_coco-panoptic.py for panoptic segmentation.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #8032 (a6719dc) into dev (c32894e) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head a6719dc differs from pull request most recent head f8c575f. Consider uploading reports for the commit f8c575f to get more accurate results

@@            Coverage Diff             @@
##              dev    #8032      +/-   ##
==========================================
+ Coverage   64.51%   64.56%   +0.05%     
==========================================
  Files         360      359       -1     
  Lines       29233    29155      -78     
  Branches     4954     4938      -16     
==========================================
- Hits        18859    18825      -34     
+ Misses       9370     9329      -41     
+ Partials     1004     1001       -3     
Flag Coverage Δ
unittests 64.55% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/utils/setup_env.py 88.00% <0.00%> (-4.00%) ⬇️
mmdet/core/bbox/assigners/sim_ota_assigner.py 80.00% <0.00%> (-3.64%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 87.35% <0.00%> (-2.30%) ⬇️
mmdet/datasets/builder.py 52.08% <0.00%> (-1.05%) ⬇️
mmdet/utils/__init__.py 100.00% <0.00%> (ø)
mmdet/utils/memory.py
...ds/panoptic_fusion_heads/maskformer_fusion_head.py 76.92% <0.00%> (+1.09%) ⬆️
mmdet/models/detectors/maskformer.py 70.00% <0.00%> (+1.42%) ⬆️
mmdet/core/bbox/samplers/random_sampler.py 80.55% <0.00%> (+5.55%) ⬆️
mmdet/models/utils/panoptic_gt_processing.py 100.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2469f78...f8c575f. Read the comment docs.

@chhluo chhluo force-pushed the rename_mask2former_configs branch from b66f487 to 1d74def Compare May 27, 2022 08:39
@ZwwWayne ZwwWayne merged commit 1623686 into open-mmlab:dev May 27, 2022
@chhluo chhluo deleted the rename_mask2former_configs branch May 27, 2022 08:55
ZwwWayne pushed a commit that referenced this pull request Jul 18, 2022
* rename

* add configs for mask2former instance segmentation

* rename panoptic seg related and add instance seg related

* update readme

* fix bug in gather_model.py

* fix link

* fix link

* update readme

* update config

* update readme

* update readme
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* rename

* add configs for mask2former instance segmentation

* rename panoptic seg related and add instance seg related

* update readme

* fix bug in gather_model.py

* fix link

* fix link

* update readme

* update config

* update readme

* update readme
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 19, 2022
* rename

* add configs for mask2former instance segmentation

* rename panoptic seg related and add instance seg related

* update readme

* fix bug in gather_model.py

* fix link

* fix link

* update readme

* update config

* update readme

* update readme
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* rename

* add configs for mask2former instance segmentation

* rename panoptic seg related and add instance seg related

* update readme

* fix bug in gather_model.py

* fix link

* fix link

* update readme

* update config

* update readme

* update readme
@Levine66
Copy link

Levine66 commented Sep 6, 2023

Hey, thanks for all of your work for Mask2Former. Recently, i am learning the code of MPFomer, which is modified from Mask2Former, and the only differences between MPFormer and Mask2Fomer are in mask2former_transformer_decoder.py and criterion.py which construct the MP training queries and loss function. I would like to convert the code from Detectron2 to MMDetection, but i am confused that I can't find the part(mask2former_transformer_decoder.py) they modified in MMDetection, it makes me hard to rewrite the code in MMDetection. So i would like to ask you guys to give me some advices to implement thisk work your time permits.

@chhluo
Copy link
Collaborator Author

chhluo commented Sep 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants