Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor pruning to projects documentation + Discussion about supporting the method in open-mmlab toolbox. #8120

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

Mxbonn
Copy link
Contributor

@Mxbonn Mxbonn commented Jun 2, 2022

Dear MMDetection maintainers,

I have recently published a journal article about "Anchor Pruning for Object Detection." (https://doi.org/10.1016/j.cviu.2022.103445). As it was built using MMDetection I would like to contribute back to the main repository.

This pull requests consists of 2 parts:
Part 1 is the request to be added to the project list as can be seen in the changes of this pull request.

Part 2 is a discussion about whether you're open to supporting anchor pruning in the open-mmlab toolbox.
This would require 2 changes: 1) my adaption makes the AnchorGenerator more general to freely define each anchor in anchor-based object detectors. This would be a change that is fully compatible with all current models released by MMDetection and it would also open up the opportunity to match the SSD-Lite anchors precisely to the ones in the official TF repository.
2) The actual anchor pruning algorithm does seem to be a good candidate to be merged into the MMRazor toolbox. This would require a rewrite of my algorithm to match the templates of this repository but if you're open to supporting my pruning method than I'm happy to adapt my code.

Kind regards,
Maxim Bonnaerens

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 5, 2022

Hi @Mxbonn ,
Thanks for your kind PR. It would be great if you would like to contribute.
I think the idea is great, we can update the AnchorGenerator to make it more general but compatible with the original functionality first. For the pruning part, it might need more consideration and I tend to migrating it to MMRazor for now.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 5, 2022

I will merge this PR first. We can create a new issue in MMRazor to discuss about that.

@ZwwWayne ZwwWayne changed the base branch from master to dev June 5, 2022 09:16
@ZwwWayne ZwwWayne merged commit 8f3a593 into open-mmlab:dev Jun 5, 2022
ZwwWayne added a commit to ZwwWayne/mmdetection that referenced this pull request Jul 28, 2022
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
triple-Mu pushed a commit to triple-Mu/mmdetection that referenced this pull request Nov 5, 2022
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants