FilterAnnotations bug fix #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version to v2.25.0
|
|
chhluo
reviewed
Jun 6, 2022
since we changed the filtering type from mask to indexes, we can no longer use ```keep.any()``` to check, because it does not work at index zero.
But we can use
```
if keep.size == 0:
if self.keep_empty:
return None
```
Codecov Report
@@ Coverage Diff @@
## dev #8136 +/- ##
==========================================
- Coverage 64.69% 64.16% -0.54%
==========================================
Files 351 361 +10
Lines 28463 29526 +1063
Branches 4807 5019 +212
==========================================
+ Hits 18414 18945 +531
- Misses 9057 9576 +519
- Partials 992 1005 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
It's better to add a unit test for filtering PolygonMasks. |
|
I've added testing that only works with the new filtering. |
|
please fix the following problems |
|
not everything is as simple as we would like =) |
chhluo
approved these changes
Jun 11, 2022
ZwwWayne
approved these changes
Jun 14, 2022
ZwwWayne
added a commit
to ZwwWayne/mmdetection
that referenced
this pull request
Jul 28, 2022
* Bug fix: open-mmlab#8131 * The better solution from chhluo * open-mmlab#8136 since we changed the filtering type from mask to indexes, we can no longer use ```keep.any()``` to check, because it does not work at index zero. But we can use ``` if keep.size == 0: if self.keep_empty: return None ``` * add a unit test for filtering PolygonMasks * W293 blank line contains whitespace Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com> Co-authored-by: m.stepanov <m.stepanov@redmadrobot.com>
This was referenced Aug 30, 2022
SakiRinn
pushed a commit
to SakiRinn/mmdetection-locount
that referenced
this pull request
Mar 17, 2023
* Bug fix: open-mmlab#8131 * The better solution from chhluo * open-mmlab#8136 since we changed the filtering type from mask to indexes, we can no longer use ```keep.any()``` to check, because it does not work at index zero. But we can use ``` if keep.size == 0: if self.keep_empty: return None ``` * add a unit test for filtering PolygonMasks * W293 blank line contains whitespace Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com> Co-authored-by: m.stepanov <m.stepanov@redmadrobot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8131
FilterAnnotation bug fix for #8131