Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix mdformat version to support python3.6 #8195

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

jbwang1997
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix mdformat version to support python3.6.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #8195 (152477a) into dev (2b05497) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #8195   +/-   ##
=======================================
  Coverage   64.17%   64.17%           
=======================================
  Files         361      361           
  Lines       29526    29526           
  Branches     5019     5019           
=======================================
  Hits        18948    18948           
  Misses       9575     9575           
  Partials     1003     1003           
Flag Coverage Δ
unittests 64.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b05497...152477a. Read the comment docs.

@ZwwWayne ZwwWayne merged commit c80f99c into open-mmlab:dev Jun 15, 2022
@jbwang1997 jbwang1997 deleted the mdformat-openmmlab branch July 21, 2022 08:14
ZwwWayne pushed a commit to ZwwWayne/mmdetection that referenced this pull request Jul 28, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants