Upgrade onnxsim to at least 0.4.0 #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
daquexian
commented
Jul 19, 2022
| ort_custom_op_path = '' | ||
| try: | ||
| from mmcv.ops import get_onnxruntime_op_path | ||
| ort_custom_op_path = get_onnxruntime_op_path() |
There was a problem hiding this comment.
ort_custom_op_path is not used after upgrade.
ZwwWayne
approved these changes
Aug 1, 2022
ZwwWayne
pushed a commit
that referenced
this pull request
Sep 9, 2022
* Upgrade onnxsim to 0.4.0 * Update pytorch2onnx.py * Update pytorch2onnx.py
SakiRinn
pushed a commit
to SakiRinn/mmdetection-locount
that referenced
this pull request
Mar 17, 2023
* Upgrade onnxsim to 0.4.0 * Update pytorch2onnx.py * Update pytorch2onnx.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm the author of onnx-simplifier. Recently I published onnxsim v0.4.0. In the latest version, dynamic input shapes are natively supported with no need for extra flags like
dynamic_input_shapes.custom_libandinput_datais also not needed.