-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yolov3 training on IPU #8552
base: dev
Are you sure you want to change the base?
yolov3 training on IPU #8552
Conversation
Hi @HuDi2018 Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #8552 +/- ##
==========================================
- Coverage 64.17% 63.53% -0.64%
==========================================
Files 361 364 +3
Lines 29530 29881 +351
Branches 5020 5079 +59
==========================================
+ Hits 18951 18986 +35
- Misses 9576 9875 +299
- Partials 1003 1020 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,4 @@ | |||
exp_name=yolov3_d53_320_273e_coco_ipu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend updating the README.md in this directory and pasting these commands in readme.
We can add a new section like Run YOLOv3 on IPU
.
We do not need to add a new bash script here since the argument is simple.
Seems this PR depends on the progress on the IPU side, so it is pending. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist