Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolov3 training on IPU #8552

Open
wants to merge 23 commits into
base: dev
Choose a base branch
from
Open

yolov3 training on IPU #8552

wants to merge 23 commits into from

Conversation

HuDi2018
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

Hi @HuDi2018

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below
image

@ZwwWayne ZwwWayne changed the base branch from master to dev August 15, 2022 05:57
@ZwwWayne ZwwWayne added this to the 2.26.0 milestone Aug 15, 2022
@ZwwWayne ZwwWayne requested review from BIGWangYuDong, RangiLyu and hhaAndroid and removed request for BIGWangYuDong August 19, 2022 05:53
demo/train_yolov3_on_ipu.sh Outdated Show resolved Hide resolved
demo/train_yolov3_on_ipu.sh Outdated Show resolved Hide resolved
tools/test.py Outdated Show resolved Hide resolved
tools/test.py Show resolved Hide resolved
mmdet/models/detectors/single_stage.py Outdated Show resolved Hide resolved
configs/yolo/yolov3_d53_320_273e_coco_ipu.py Show resolved Hide resolved
configs/yolo/yolov3_d53_320_273e_coco_ipu.py Outdated Show resolved Hide resolved
configs/yolo/yolov3_d53_320_273e_coco_ipu.py Outdated Show resolved Hide resolved
mmdet/apis/test.py Outdated Show resolved Hide resolved
mmdet/apis/train.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Attention: 288 lines in your changes are missing coverage. Please review.

Comparison is base (3b72b12) 64.17% compared to head (26476e9) 63.53%.
Report is 96 commits behind head on dev.

Files Patch % Lines
mmdet/models/dense_heads/yolo_head_ipu.py 11.45% 115 Missing and 1 partial ⚠️
mmdet/datasets/pipelines/ipu_pipelines.py 23.80% 80 Missing ⚠️
mmdet/models/backbones/darknet_ipu.py 16.07% 46 Missing and 1 partial ⚠️
mmdet/apis/test.py 5.00% 38 Missing ⚠️
mmdet/apis/train.py 0.00% 5 Missing ⚠️
mmdet/models/detectors/single_stage.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8552      +/-   ##
==========================================
- Coverage   64.17%   63.53%   -0.64%     
==========================================
  Files         361      364       +3     
  Lines       29530    29881     +351     
  Branches     5020     5079      +59     
==========================================
+ Hits        18951    18986      +35     
- Misses       9576     9875     +299     
- Partials     1003     1020      +17     
Flag Coverage Δ
unittests 63.53% <17.24%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

configs/yolo/yolov3_d53_320_273e_coco_ipu.py Show resolved Hide resolved
mmdet/datasets/pipelines/ipu_pipelines.py Show resolved Hide resolved
mmdet/datasets/pipelines/ipu_pipelines.py Outdated Show resolved Hide resolved
mmdet/models/dense_heads/yolo_head.py Outdated Show resolved Hide resolved
mmdet/models/dense_heads/yolo_head.py Outdated Show resolved Hide resolved
mmdet/models/dense_heads/yolo_head.py Outdated Show resolved Hide resolved
mmdet/models/dense_heads/dense_test_mixins.py Outdated Show resolved Hide resolved
mmdet/models/detectors/single_stage.py Show resolved Hide resolved
mmdet/apis/test.py Outdated Show resolved Hide resolved
@RangiLyu RangiLyu self-requested a review August 26, 2022 09:08
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,4 @@
exp_name=yolov3_d53_320_273e_coco_ipu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend updating the README.md in this directory and pasting these commands in readme.
We can add a new section like Run YOLOv3 on IPU.
We do not need to add a new bash script here since the argument is simple.

configs/yolo/yolov3_d53_320_273e_coco_ipu.py Outdated Show resolved Hide resolved
@ZwwWayne
Copy link
Collaborator

Seems this PR depends on the progress on the IPU side, so it is pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants