Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor standard roi head with boxlist. #8658

Merged
merged 19 commits into from
Sep 28, 2022
Merged

[Refactor] Refactor standard roi head with boxlist. #8658

merged 19 commits into from
Sep 28, 2022

Conversation

jbwang1997
Copy link
Collaborator

@jbwang1997 jbwang1997 commented Aug 29, 2022 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refactor standard roi head with boxlist
wait for merging of #8625

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added this to the 3.0.0rc1 milestone Aug 30, 2022
@jbwang1997 jbwang1997 force-pushed the standard_roi_head branch 5 times, most recently from c9c0b7b to e8305ca Compare September 5, 2022 06:19
@zytx121 zytx121 added the v-3.x label Sep 6, 2022
@zytx121 zytx121 mentioned this pull request Sep 6, 2022
Merged
3 tasks
chhluo
chhluo reviewed Sep 6, 2022
View reviewed changes
mmdet/models/utils/misc.py Outdated Show resolved Hide resolved
mmdet/models/utils/misc.py Outdated Show resolved Hide resolved
mmdet/models/task_modules/samplers/sampling_result.py Outdated Show resolved Hide resolved
mmdet/models/task_modules/coders/yolo_bbox_coder.py Outdated Show resolved Hide resolved
mmdet/models/task_modules/assigners/iou2d_calculator.py Outdated Show resolved Hide resolved
@zytx121
Copy link
Collaborator

zytx121 commented Sep 8, 2022

LGTM

chhluo
chhluo previously approved these changes Sep 8, 2022
View reviewed changes
@jbwang1997
Copy link
Collaborator Author

I also move all box operations into mmdet.structures.bbox.

RangiLyu
RangiLyu reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "boxlist" should be changed.

@jbwang1997
Copy link
Collaborator Author

The word "boxlist" should be changed.

I have replaced all boxlist with box type.

RangiLyu
RangiLyu previously approved these changes Sep 14, 2022
View reviewed changes
ZwwWayne
ZwwWayne previously approved these changes Sep 14, 2022
View reviewed changes
@zytx121
Copy link
Collaborator

zytx121 commented Sep 21, 2022

LGTM

chhluo
chhluo reviewed Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@chhluo chhluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase it on the latest dev-3.x

RangiLyu
RangiLyu approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 40d4f99 into open-mmlab:dev-3.x Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhluo chhluo chhluo left review comments

@RangiLyu RangiLyu RangiLyu approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees

@Czm369 Czm369

Labels
v-3.x
Projects
None yet
Milestone
3.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbwang1997 @zytx121 @RangiLyu @chhluo @ZwwWayne @Czm369