Fix floordiv warning. #8738
Merged
Fix floordiv warning. #8738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZwwWayne The code is re-summited here. |
|
Hi @JiayuXu0 , |
The conflict has been fixed. |
RangiLyu
previously approved these changes
Sep 14, 2022
ZwwWayne
previously approved these changes
Sep 19, 2022
ZwwWayne
approved these changes
Sep 21, 2022
ZwwWayne
added a commit
that referenced
this pull request
Sep 26, 2022
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In SOLO code, floordiv is deprecated, and its behavior will change in a future version of pytorch.
Modification
torch.div(a, b, rounding_mode='trunc') is used to replace floordiv.