Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR from 3.x_doc] Update FasterRCNN doc with the right URL of R-50-FPN with BoundedIoULoss #8805

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

songyuc
Copy link
Contributor

@songyuc songyuc commented Sep 15, 2022

Motivation

The original the URL of "R-50-FPN BoundedIoULoss" do not point to the corresponding config.

Modification

Modified the URL of R-50-FPN with BoundedIoULoss.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.

@songyuc songyuc changed the title [PR from 3.x doc] Update FasterRCNN doc with the right URL of R-50-FPN with BoundedIoULoss [PR from 3.x_doc] Update FasterRCNN doc with the right URL of R-50-FPN with BoundedIoULoss Sep 15, 2022
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022

CLA assistant check
All committers have signed the CLA.

@RangiLyu RangiLyu changed the base branch from master to dev-3.x September 15, 2022 11:44
@RangiLyu
Copy link
Member

The lint failed, Please run pip install pre-commit and then run pre-commit run --all-files to fix the lint.

@songyuc
Copy link
Contributor Author

songyuc commented Sep 15, 2022

The lint failed, Please run pip install pre-commit and run pre-commit run --all-files to fix the lint.

Now, I just check it by clicking my modified URL, then manually replacing "master" with "3.x" and refreshing the page.
If the config page is shown normally, I can confirm it will be right in the next release from 3.x to the coming master.

@songyuc songyuc closed this Sep 15, 2022
@songyuc songyuc reopened this Sep 15, 2022
Copy link
Contributor Author

@songyuc songyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commit again

Relative path is used instead of URL.

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
RangiLyu
RangiLyu previously approved these changes Sep 17, 2022
ZwwWayne
ZwwWayne previously approved these changes Sep 17, 2022
@ZwwWayne
Copy link
Collaborator

Hi @songyuc ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@songyuc songyuc dismissed stale reviews from ZwwWayne and RangiLyu via 78a8cfb September 17, 2022 16:58
@songyuc
Copy link
Contributor Author

songyuc commented Sep 17, 2022

Hi @songyuc , Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR? The details can be found by clicking the item of lint check as shown below image

Hi, @ZwwWayne! Thanks for your patient review. I have fixed the the lint issue.

@ZwwWayne ZwwWayne merged commit 0656e45 into open-mmlab:dev-3.x Sep 19, 2022
@songyuc songyuc deleted the 3.x_doc branch September 19, 2022 08:42
ZwwWayne pushed a commit that referenced this pull request Sep 26, 2022
…edIoULoss (#8805)

* Update the right URL of R-50-FPN with BoundedIoULoss

* Update the right URL of R-50-FPN at 2141

* Update configs/faster_rcnn/README.md

Relative path is used instead of URL.

Co-authored-by: RangiLyu <lyuchqi@gmail.com>

* Fix the lint issue in configs/faster_rcnn/README.md after pulling the latest version

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
@OpenMMLab-Assistant005
Copy link

Hi @songyuc !First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants