Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: change config content #8810

Merged
merged 8 commits into from
Nov 14, 2022
Merged

[Refactor]: change config content #8810

merged 8 commits into from
Nov 14, 2022

Conversation

yue-heu
Copy link
Contributor

@yue-heu yue-heu commented Sep 15, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
RangiLyu
RangiLyu previously approved these changes Sep 17, 2022
@ZwwWayne ZwwWayne changed the base branch from 3.x to dev-3.x September 17, 2022 12:40
@ZwwWayne ZwwWayne dismissed RangiLyu’s stale review September 17, 2022 12:40

The base branch was changed.

@ZwwWayne
Copy link
Collaborator

Hi @yuewangg ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@ZwwWayne ZwwWayne added this to the 3.0.0rc1 milestone Sep 17, 2022
@yue-heu
Copy link
Contributor Author

yue-heu commented Sep 19, 2022

I have submitted it again, please check it.

@ZwwWayne ZwwWayne modified the milestones: 3.0.0rc2, 3.0.0rc3 Oct 21, 2022
@ZwwWayne ZwwWayne merged commit 491a40c into open-mmlab:dev-3.x Nov 14, 2022
ZwwWayne added a commit that referenced this pull request Nov 14, 2022
* [Refactor]: change config content

* [Refactor]: change config content

* [Refactor]: change config content

* [Refactor]: change config content

* [Refactor]: change config content

Co-authored-by: RangiLyu <lyuchqi@gmail.com>

* [Refactor]: change config content

* fix lint

Co-authored-by: RangiLyu <lyuchqi@gmail.com>
Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Co-authored-by: Yue Zhou <592267829@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants