copypaste_based_on_bbox #8905

JarvisKevin · 2022-09-28T09:49:56Z

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

It's much more expensive for us to annotate a mask label than bbox. So, How copypaste can be utilized when only bbox provided?

Modification

If only gt_bboxes provided, gt_masks can be generated by the gt_bboxes to get a second best preformance.

CLAassistant · 2022-09-28T09:50:02Z

All committers have signed the CLA.

ZwwWayne · 2022-09-28T11:15:13Z

Hi @JarvisKevin

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below

JarvisKevin · 2022-09-28T11:17:47Z

[MMDet] copypaste with bbox - Jarvis的文章 - 知乎
https://zhuanlan.zhihu.com/p/568957551

JarvisKevin · 2022-09-28T11:19:51Z

Is there any idea to test this change in test_transforms.py?

Czm369 · 2022-09-28T11:55:35Z

Thanks for you kind PR! CopyPaste with the PR can be directly used in object detection. Can you show images with CopyPaste based on bboxes? In addition, verify that CopyPaste can be used normally with with_mask=Fasle for LoadAnnotations in the unit test, and there is no gt_masks in the returned results.

JarvisKevin · 2022-09-28T12:44:50Z

@Czm369 Thanks for your suggestion of the unit_test. The picture with cp based on bboxes was posted on https://zhuanlan.zhihu.com/p/568957551, maybe you can refer it.

Czm369 · 2022-09-28T12:53:07Z

The unit test for CopyPaste is at

mmdetection/tests/test_data/test_pipelines/test_transform/test_transform.py

Line 1030 in 9d3e162

def test_copypaste():

mmdet/datasets/pipelines/transforms.py

Czm369

LGTM

mmdet/datasets/pipelines/transforms.py

codecov · 2022-10-08T03:26:00Z

Codecov Report

Base: 64.12% // Head: 64.10% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (7559768) compared to base (9d3e162).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head 7559768 differs from pull request most recent head 27528ab. Consider uploading reports for the commit 27528ab to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #8905      +/-   ##
==========================================
- Coverage   64.12%   64.10%   -0.03%     
==========================================
  Files         361      361              
  Lines       29536    29558      +22     
  Branches     5022     4925      -97     
==========================================
+ Hits        18939    18947       +8     
- Misses       9580     9594      +14     
  Partials     1017     1017

Flag	Coverage Δ
unittests	`64.10% <90.90%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdet/datasets/pipelines/transforms.py	`76.18% <90.90%> (+0.22%)`	⬆️
mmdet/core/bbox/samplers/random_sampler.py	`75.00% <0.00%> (-5.56%)`	⬇️
mmdet/models/detectors/cornernet.py	`94.87% <0.00%> (-5.13%)`	⬇️
mmdet/models/dense_heads/corner_head.py	`68.33% <0.00%> (-1.39%)`	⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py	`72.36% <0.00%> (-1.32%)`	⬇️
mmdet/core/hook/wandblogger_hook.py	`14.91% <0.00%> (-0.13%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet/datasets/pipelines/transforms.py

drop parameter "using_cutmix" add indicator "paste_by_box"

hhaAndroid · 2022-10-27T04:40:20Z

@JarvisKevin Please fix the lint

hhaAndroid · 2022-10-27T04:42:16Z

mmdet/datasets/pipelines/transforms.py

@@ -2813,6 +2814,42 @@ def get_indexes(self, dataset):
        """
        return random.randint(0, len(dataset))

+    def gen_masks_from_bboxes(self, bboxes, img_shape):


Does the dev-3.x branch need to be updated in sync?

Yes, we should migrate the change.

ZwwWayne · 2023-01-29T11:03:01Z

We need to migrate this PR to MMDet 3.x

…pen-mmlab#8905) * copypaste_based_on_bbox * docformatter * formatter again * fix bug of dict get method in check_gt_masks * test copypaste based on bbox * change mask generating method * docformatter * docformatter * update comment 'result' to 'results' * rename * Update transforms.py * Update transforms.py * Update transforms.py * rename 'mask_gen' to 'using_cutmix' * yapf * Add files via upload * yapf * paste_by_box drop parameter "using_cutmix" add indicator "paste_by_box"

copypaste_based_on_bbox

dfa4c5f

mm-assistant bot assigned jbwang1997 Sep 28, 2022

docformatter

0536193

ZwwWayne requested a review from Czm369 September 28, 2022 11:15

ZwwWayne assigned Czm369 and unassigned jbwang1997 Sep 28, 2022

ZwwWayne added this to the 2.27.0 milestone Sep 28, 2022

JarvisKevin added 6 commits September 29, 2022 11:42

formatter again

9fe51d9

fix bug of dict get method in check_gt_masks

2d118e4

test copypaste based on bbox

73ada1b

change mask generating method

621ac38

docformatter

fd9cbea

docformatter

5b99846

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

update comment 'result' to 'results'

de0be76

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

rename

c3dad67

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Update transforms.py

22300a8

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Czm369 approved these changes Sep 29, 2022

View reviewed changes

JarvisKevin added 2 commits September 29, 2022 18:51

Update transforms.py

9bf35e7

Update transforms.py

7bac786

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

Czm369 reviewed Sep 29, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

rename 'mask_gen' to 'using_cutmix'

34fb567

JarvisKevin marked this pull request as ready for review September 30, 2022 01:42

JarvisKevin added 3 commits September 30, 2022 10:09

yapf

d10657f

Add files via upload

e839cc6

yapf

7559768

ZwwWayne requested a review from hhaAndroid October 9, 2022 13:11

hhaAndroid reviewed Oct 18, 2022

View reviewed changes

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved

paste_by_box

27528ab

drop parameter "using_cutmix" add indicator "paste_by_box"

ZwwWayne requested a review from hhaAndroid October 27, 2022 03:58

hhaAndroid approved these changes Oct 27, 2022

View reviewed changes

hhaAndroid reviewed Oct 27, 2022

View reviewed changes

hhaAndroid self-requested a review October 27, 2022 04:42

ZwwWayne approved these changes Oct 28, 2022

View reviewed changes

ZwwWayne merged commit 1f8b195 into open-mmlab:dev Oct 28, 2022

ZwwWayne added this to In progress in Migration via automation Oct 28, 2022

JarvisKevin deleted the copypaste_based_on_bbox branch November 14, 2022 03:01

ZwwWayne moved this from In progress to To do in Migration Jan 29, 2023

ZwwWayne mentioned this pull request Jan 29, 2023

Migrate #8905 PR to MMDet 3.x #9686

Open

ZwwWayne removed this from To do in Migration Jan 29, 2023

nijkah mentioned this pull request Feb 28, 2023

[Feature] Support CopyPaste for RotatedBoxes open-mmlab/mmrotate#657

Closed

nijkah mentioned this pull request Jun 14, 2023

[Feature] Support CopyPaste when mask is not available #10509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

copypaste_based_on_bbox #8905

copypaste_based_on_bbox #8905

JarvisKevin commented Sep 28, 2022 •

edited by Czm369

Loading

CLAassistant commented Sep 28, 2022 •

edited

Loading

ZwwWayne commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

Czm369 commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

Czm369 commented Sep 28, 2022

Czm369 left a comment

codecov bot commented Oct 8, 2022 •

edited

Loading

hhaAndroid commented Oct 27, 2022

hhaAndroid Oct 27, 2022

ZwwWayne Oct 28, 2022

ZwwWayne commented Jan 29, 2023

copypaste_based_on_bbox #8905

copypaste_based_on_bbox #8905

Conversation

JarvisKevin commented Sep 28, 2022 • edited by Czm369 Loading

Motivation

Modification

CLAassistant commented Sep 28, 2022 • edited Loading

ZwwWayne commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

Czm369 commented Sep 28, 2022

JarvisKevin commented Sep 28, 2022

Czm369 commented Sep 28, 2022

Czm369 left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 8, 2022 • edited Loading

Codecov Report

hhaAndroid commented Oct 27, 2022

hhaAndroid Oct 27, 2022

Choose a reason for hiding this comment

ZwwWayne Oct 28, 2022

Choose a reason for hiding this comment

ZwwWayne commented Jan 29, 2023

JarvisKevin commented Sep 28, 2022 •

edited by Czm369

Loading

CLAassistant commented Sep 28, 2022 •

edited

Loading

codecov bot commented Oct 8, 2022 •

edited

Loading