Fix bugs when ploting loss curve by analyze_logs.py #8944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
do I need to recommit the PR after installing pre-commit in my local repository? |
|
|
Ok, I have already pushed it after updating my local repository |
Seems you did not push to GitHub. |
wanghonglie
approved these changes
Oct 18, 2022
RangiLyu
approved these changes
Oct 18, 2022
MambaWong
pushed a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 20, 2022
MambaWong
pushed a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 21, 2022
MambaWong
pushed a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 22, 2022
MambaWong
pushed a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
When ploting loss_cls of some run using analyze_logs.py, the numbers of xs and ys in function plot_curve(line 83,84) are not the same! Therefore causing error when running plt.plot().
After debug, I found that this problem was caused by the quantity mismatch of values of key 'step' and key 'loss_cls' in log_dicts returned by function load_json_logs. And this problem occured because validation lines in json log file producing after training also contains key 'step', causing the number of key 'step' in log_dicts 12 more than that in key 'loss_cls'.
Modification
Simply add val_flag variable to judge whether current line is validation line, if it is, do not add the step info into the log_dicts.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
no