Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bitmap mask translate when out_shape is different. #8993

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

RangiLyu
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix bug of bitmap mask translate when out_shape is different.

Modification

Padding the mask before translating.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RangiLyu RangiLyu added bug Something isn't working v-3.x labels Oct 11, 2022
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BIGWangYuDong
Copy link
Collaborator

We can also modify this in 2.x

@ZwwWayne ZwwWayne merged commit 5164f26 into open-mmlab:dev-3.x Oct 12, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc2 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v-3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants