minor typo

[Ryoo72]

neg_pos_up -> neg_pos_ub
minor typo fix

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Debugging today was difficult because searching with ctrl+shift+f was not possible due to a typo.

Modification

I just changed one letter. neg_pos_up -> neg_pos_ub

I just want to fix this typo, and I was thinking about whether to drop it in an issue or make a pull request and post it here. If you've read this, I'd appreciate it if you could correct the typo. thx !

Checklist

1. Pre-commit or other linting tools are used to fix the potential lint issues.
2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
4. The documentation has been modified accordingly, like docstring or example tutorials.

[CLAassistant]

All committers have signed the CLA.

[ZwwWayne]

Hi @Ryoo72

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below

[codecov]

Codecov Report

Base: 64.12% // Head: 64.07% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8834dde) compared to base (9d3e162).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9033      +/-   ##
==========================================
- Coverage   64.12%   64.07%   -0.06%     
==========================================
  Files         361      361              
  Lines       29536    29536              
  Branches     5022     4920     -102     
==========================================
- Hits        18939    18924      -15     
- Misses       9580     9593      +13     
- Partials     1017     1019       +2     

Flag	Coverage Δ
unittests	64.07% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdet/core/bbox/samplers/random_sampler.py	75.00% <ø> (-5.56%)	⬇️
mmdet/models/detectors/cornernet.py	94.87% <0.00%> (-5.13%)	⬇️
mmdet/models/dense_heads/corner_head.py	68.33% <0.00%> (-1.39%)	⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py	72.36% <0.00%> (-1.32%)	⬇️
mmdet/datasets/pipelines/transforms.py	75.56% <0.00%> (-0.41%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Ryoo72]

Hi @Ryoo72

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below

I really appreciate your detailed explanation ! Thank you :)