[Fix] Add ignore_key in voc dataset to fix error
#9058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangiLyu
reviewed
Oct 18, 2022
RangiLyu
previously approved these changes
Nov 1, 2022
|
The mmengine_minimum_version should be updated to 0.3.0 to avoid bc breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
VOCDataset has
DATASET_TYPEkey in metainfo which is different in VOC2007 and VOC2012. This will get an error when using ConcatDataset. Hence, we add anignore_keyin ConcatDataset to fix this error.Modification
add an
ignore_keyin ConcatDataset to fix this error.This PR should be merged after open-mmlab/mmengine#556 has been merged in MMEngine.
Before merging this PR, #8847 can be temporarily fixed VOC ConcatDataset error.
NOTE
This PR change the minimum version of mmengine to 0.3.0.