Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Fix horizontal boxes #9140

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

Czm369
Copy link
Collaborator

@Czm369 Czm369 commented Oct 26, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix corner2hbox of HorizontalBoxes for supporting empty bboxes.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@jbwang1997
Copy link
Collaborator

It's better to add UT to test empty HorizontalBoxes functions.

@ZwwWayne ZwwWayne linked an issue Oct 28, 2022 that may be closed by this pull request
3 tasks
@ZwwWayne ZwwWayne added this to the 3.0.0rc3 milestone Oct 28, 2022
@ZwwWayne ZwwWayne merged commit 5897b32 into open-mmlab:3.x Nov 2, 2022
ZwwWayne pushed a commit that referenced this pull request Nov 4, 2022
* Fix corner2hbox of HorizontalBoxes for supporting empty bboxes.

* Test empty boxes for HorizontalBoxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

softteacher in 3.x error because can‘t send empty gt
5 participants