Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix solov2 cannot dealing with empty gt image #9185

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

BIGWangYuDong
Copy link
Collaborator

Solve PR: #9159

loss_mask may empty when num_pos = 0. Hence, fix the num_pos=0 case to support dealing with empty gt image

Copy link
Collaborator

@Czm369 Czm369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 64.21% // Head: 64.18% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d61c060) compared to base (5d06246).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9185      +/-   ##
==========================================
- Coverage   64.21%   64.18%   -0.03%     
==========================================
  Files         361      361              
  Lines       29567    29567              
  Branches     5029     5029              
==========================================
- Hits        18985    18978       -7     
- Misses       9573     9583      +10     
+ Partials     1009     1006       -3     
Flag Coverage Δ
unittests 64.16% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/solov2_head.py 10.13% <0.00%> (ø)
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 68.33% <0.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit 13f8683 into open-mmlab:dev Oct 31, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* [Fix] Fix solov2 cannot dealing with empty gt image

* minor fix
@BIGWangYuDong BIGWangYuDong deleted the fix_solov2 branch April 27, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v-2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants