Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Condinst #9223

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Conversation

JosonChan1998
Copy link
Contributor

@JosonChan1998 JosonChan1998 commented Nov 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Condition instance segmentation methods. The results are listed below:

MS_R_50_1x box AP mask AP
origin 39.7 35.7
ours(12e) 39.6 35.2
ours(90k) 39.9 35.5

The reproduction results are still a little behind, probably because there are more iterations in detectron2.

Modification

  1. configs/condinst
  2. mmdet/models/detectors/condinst.py
  3. mmdet/models/dense_heads/condinst_head.py
  4. mmdet/models/utils/misc.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022

CLA assistant check
All committers have signed the CLA.

@JosonChan1998
Copy link
Contributor Author

@RangiLyu Hi~ Any progress?

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reproduction results are still a little behind, probably because there are more iterations in detectron2.

Is the precision of the inference aligned? Can this implementation get the same box and mask AP with a converted weight from the original version?

@hhaAndroid
Copy link
Collaborator

@JosonChan1998 I think this PR is very well. Just need to add unit tests, I have no other comments.

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me now. Would you like to write the README.md file?

Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to use polygon masks. And after this change, the config file name should be renamed to condinst_r50_fpn_ms-poly-90k_coco.py

@JosonChan1998
Copy link
Contributor Author

Remember to use polygon masks. And after this change, the config file name should be renamed to condinst_r50_fpn_ms-poly-90k_coco.py

Done.

RangiLyu
RangiLyu previously approved these changes Nov 23, 2022
@RangiLyu RangiLyu changed the base branch from 3.x to dev-3.x November 23, 2022 06:01
@RangiLyu RangiLyu dismissed their stale review November 23, 2022 06:01

The base branch was changed.

@ZwwWayne ZwwWayne merged commit 79c8295 into open-mmlab:dev-3.x Nov 23, 2022
@JosonChan1998 JosonChan1998 deleted the condinst branch November 30, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants