Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support mmdet with NPU backend #9267

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

wangjiangben-hw
Copy link

@wangjiangben-hw wangjiangben-hw commented Nov 8, 2022

Motivation

Added NPU(ascending device) support in mmdet

Modification

The main modification points are:

  1. add NPUDataParallel、NPUDistributedDataParallel

BC-breaking (Optional)

None

Use cases (Optional)

Provides configuration information that can be worked on the NPU

config map map_gpu
configs/fcos/fcos_r50_caffe_fpn_gn-head_1x_bs8x8_coco.py 36.2 36.1
configs/ssd/ssd300_coco_fp16.py 25.6 25.5

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne changed the base branch from master to dev November 8, 2022 07:54
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Nov 8, 2022

Hi @wangjiangben-hw

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below
image

@wangjiangben-hw wangjiangben-hw changed the title Main [NPU] add NPU support Nov 8, 2022
tools/test.py Show resolved Hide resolved
@wangjiangben-hw wangjiangben-hw changed the title [NPU] add NPU support [Feature] Support mmdet with NPU backend Nov 8, 2022
@wangjiangben-hw
Copy link
Author

Hi @wangjiangben-hw

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below image

done

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 64.18% // Head: 64.16% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0ad58c5) compared to base (bea71f0).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9267      +/-   ##
==========================================
- Coverage   64.18%   64.16%   -0.02%     
==========================================
  Files         361      361              
  Lines       29557    29583      +26     
  Branches     5027     5033       +6     
==========================================
+ Hits        18972    18983      +11     
- Misses       9580     9591      +11     
- Partials     1005     1009       +4     
Flag Coverage Δ
unittests 64.14% <6.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 47.00% <0.00%> (-1.67%) ⬇️
mmdet/apis/train.py 13.40% <0.00%> (-0.29%) ⬇️
mmdet/utils/util_distribution.py 22.50% <5.88%> (-7.13%) ⬇️
mmdet/core/data_structures/general_data.py 82.55% <14.28%> (-3.37%) ⬇️
mmdet/core/bbox/samplers/random_sampler.py 75.00% <0.00%> (-5.56%) ⬇️
mmdet/models/dense_heads/corner_head.py 69.72% <0.00%> (+1.38%) ⬆️
mmdet/core/bbox/assigners/sim_ota_assigner.py 83.63% <0.00%> (+3.63%) ⬆️
mmdet/models/detectors/cornernet.py 100.00% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

configs/fcos/fcos_r50_caffe_fpn_gn-head_1x_bs8x8_coco.py Outdated Show resolved Hide resolved
configs/fcos/fcos_r50_caffe_fpn_gn-head_1x_bs8x8_coco.py Outdated Show resolved Hide resolved
mmdet/apis/train.py Outdated Show resolved Hide resolved
tools/test.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 3e36d5c into open-mmlab:dev Nov 16, 2022
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants