Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Faster RCNN fp16 config link fix #9366

Merged
merged 3 commits into from Dec 12, 2022
Merged

Conversation

apatsekin
Copy link
Contributor

README: Faster RCNN fp16 config link fix

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

README: Faster RCNN fp16 config link fix
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne changed the base branch from master to dev November 23, 2022 07:48
@ZwwWayne ZwwWayne added this to the 2.27.0 milestone Nov 23, 2022
@ZwwWayne
Copy link
Collaborator

Hi @apatsekin ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@hhaAndroid
Copy link
Collaborator

@apatsekin

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 64.19% // Head: 64.17% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (3e56e9a) compared to base (e71b499).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9366      +/-   ##
==========================================
- Coverage   64.19%   64.17%   -0.03%     
==========================================
  Files         361      361              
  Lines       29544    29583      +39     
  Branches     5023     5033      +10     
==========================================
+ Hits        18966    18984      +18     
- Misses       9570     9590      +20     
- Partials     1008     1009       +1     
Flag Coverage Δ
unittests 64.14% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/utils/util_distribution.py 22.50% <0.00%> (-7.13%) ⬇️
mmdet/core/data_structures/general_data.py 82.55% <0.00%> (-3.37%) ⬇️
mmdet/apis/inference.py 47.00% <0.00%> (-1.67%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <0.00%> (-1.32%) ⬇️
mmdet/models/detectors/rpn.py 51.47% <0.00%> (-0.84%) ⬇️
mmdet/apis/train.py 13.40% <0.00%> (-0.29%) ⬇️
mmdet/datasets/cityscapes.py 13.37% <0.00%> (ø)
mmdet/datasets/pipelines/transforms.py 76.22% <0.00%> (+0.22%) ⬆️
...det/core/bbox/assigners/mask_hungarian_assigner.py 97.43% <0.00%> (+8.79%) ⬆️
mmdet/core/bbox/assigners/hungarian_assigner.py 97.36% <0.00%> (+8.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit 97edaac into open-mmlab:dev Dec 12, 2022
thmegy pushed a commit to thmegy/mmdetection that referenced this pull request May 5, 2023
* README: Faster RCNN fp16 config link fix

README: Faster RCNN fp16 config link fix

* Update README.md

* Update README.md

Co-authored-by: Yue Zhou <592267829@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants