Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove legacy builder.py #9479

Merged
merged 6 commits into from
Dec 19, 2022

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Dec 12, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Remove legacy build functions and replace them with Registry.build()

resolve #9475

Modification

Remove all build_detector and build_dataset.

BC-breaking

APIs in mmdet.models.builder and mmdet.datasets.builder are no longer available.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RangiLyu RangiLyu added WIP Working in progress refactor v-3.x labels Dec 12, 2022
@RangiLyu RangiLyu removed the WIP Working in progress label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants