New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete parrots-awared code of roi extractor #9503
Conversation
Hi @chenyuwang814 , Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 64.15% // Head: 64.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #9503 +/- ##
==========================================
- Coverage 64.15% 64.13% -0.03%
==========================================
Files 361 361
Lines 29583 29581 -2
Branches 5033 5032 -1
==========================================
- Hits 18980 18971 -9
- Misses 9599 9602 +3
- Partials 1004 1008 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We need to migrate this PR into MMDet 3.x |
Dear chenyuwang814, |
Motivation
SenseParrots has already aligned some apis of autograd with pytorch so that requiring grad of "feats" is no longer needed by parrots, which will also cause an error.
Modification
We deleted a bunch of parrots-awared code within roi extractor so that the parameter "feats" no longer requires grad.