Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete parrots-awared code of roi extractor #9503

Merged
merged 1 commit into from Dec 19, 2022

Conversation

chenyuwang814
Copy link

@chenyuwang814 chenyuwang814 commented Dec 16, 2022

Motivation

SenseParrots has already aligned some apis of autograd with pytorch so that requiring grad of "feats" is no longer needed by parrots, which will also cause an error.

Modification

We deleted a bunch of parrots-awared code within roi extractor so that the parameter "feats" no longer requires grad.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@chenyuwang814 chenyuwang814 changed the title delete code for parrots delete parrots-awared code of roi Dec 16, 2022
@chenyuwang814 chenyuwang814 changed the title delete parrots-awared code of roi delete parrots-awared code of roi extractor Dec 16, 2022
@ZwwWayne ZwwWayne changed the base branch from master to dev December 19, 2022 02:49
@ZwwWayne ZwwWayne added this to In progress in Migration via automation Dec 19, 2022
@ZwwWayne ZwwWayne added this to the 2.27.0 milestone Dec 19, 2022
@ZwwWayne
Copy link
Collaborator

Hi @chenyuwang814 ,

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below
image

@ZwwWayne ZwwWayne assigned RangiLyu and unassigned BIGWangYuDong Dec 19, 2022
Migration automation moved this from In progress to Reviewer approved Dec 19, 2022
Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 64.15% // Head: 64.13% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (81c3ba5) compared to base (31c8495).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9503      +/-   ##
==========================================
- Coverage   64.15%   64.13%   -0.03%     
==========================================
  Files         361      361              
  Lines       29583    29581       -2     
  Branches     5033     5032       -1     
==========================================
- Hits        18980    18971       -9     
- Misses       9599     9602       +3     
- Partials     1004     1008       +4     
Flag Coverage Δ
unittests 64.11% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heads/roi_extractors/single_level_roi_extractor.py 92.00% <ø> (+3.53%) ⬆️
mmdet/utils/setup_env.py 88.00% <0.00%> (-4.00%) ⬇️
mmdet/core/bbox/assigners/sim_ota_assigner.py 80.00% <0.00%> (-3.64%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 87.35% <0.00%> (-2.30%) ⬇️
mmdet/core/bbox/assigners/max_iou_assigner.py 72.36% <0.00%> (-1.32%) ⬇️
mmdet/datasets/builder.py 52.08% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit ad86eaa into open-mmlab:dev Dec 19, 2022
Migration automation moved this from Reviewer approved to Done Dec 19, 2022
@ZwwWayne ZwwWayne moved this from Done to To do in Migration Jan 29, 2023
@ZwwWayne
Copy link
Collaborator

We need to migrate this PR into MMDet 3.x

@ZwwWayne ZwwWayne removed this from To do in Migration Jan 29, 2023
@openmmlab-bot
Copy link
Collaborator

Dear chenyuwang814,
First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord:https://discord.gg/raweFPmdzG. We sincerely hope you will join us!
Best regards! @chenyuwang814

thmegy pushed a commit to thmegy/mmdetection that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants