Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation loss logging #9663

Merged

Conversation

eantono
Copy link

@eantono eantono commented Jan 24, 2023

Motivation

The validation loss is currently not logged in the setting of both train and val workflow modes.

The problem is described in this issue:
open-mmlab/mmsegmentation#1396
This PR replicates the changes made in this PR to the mmsegmentation library: open-mmlab/mmsegmentation#1494

Modification

val_step is modified to add _val suffix to all validation losses, to distinguish those losses from those in the training step. This enables both training and validation loss logging.

@ZwwWayne ZwwWayne changed the base branch from master to dev January 28, 2023 03:37
@ZwwWayne ZwwWayne merged commit fd76d2b into open-mmlab:dev Jan 28, 2023
@jason102811
Copy link

Hi @eantono !First of all, we want to express our gratitude for your significant PR in the MMDet. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

thmegy pushed a commit to thmegy/mmdetection that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants