Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] modify the img in inference_detector(model, img) #9739

Open
wants to merge 3 commits into
base: dev-3.x
Choose a base branch
from

Conversation

chg0901
Copy link
Contributor

@chg0901 chg0901 commented Feb 8, 2023

In inference_detector(model, img), the img should be an image object or matrix not an img path

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

In `inference_detector(model, img)`, the `img ` should be an image object or matrix not an img path
@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Feb 8, 2023

Hi @chg0901

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below
image

@ZwwWayne ZwwWayne requested a review from zwhus February 8, 2023 13:55
@ZwwWayne ZwwWayne assigned zwhus and unassigned zytx121 Feb 8, 2023
@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Feb 8, 2023
@chg0901
Copy link
Contributor Author

chg0901 commented Feb 8, 2023

Hi @chg0901

Thanks for your kind PR. It seems that CLA is not signed. Could you sign the CLA so that eventually we could merge this PR after review? You can check the contents and follow the instruction in the communication box shown as below image

Hello, @ZwwWayne , I have signed the CLA. Thank you for your help. Have a nice day~

@ZwwWayne
Copy link
Collaborator

Hi @chg0901 ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

Please fix the lint issue. You can install pre-commit hook on your machine like following:

pip install -U pre-commit
cd mmdeploy
pre-commit install

Then you can run pre-commit run --all-file to check whether there are lint errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants