[Fix] Updata bbox_3d info in cam_instances for mono3d-det task
#2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix point cloud loop visualization error * fix browse_dataset * fix browse_dataset * support saving lidar_det Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn>
…pen-mmlab#1863) * add instance statistics before and after through pipeline * add docstring * support showing cat-wise instance statistics * show all statistics of the dataset * small fix * polish code * show table * small fix * rename some varibles
* fix waymo converter * [Fix] Update waymo converter and fix lint * Update waymo_converter.py * Update kitti_converter.py * Update update_infos_to_v2.py * revert
…-mmlab#2031) * fix paths on Windows by using `pathlib` * refactor Path import
|
I suggest to modify the converter script, not dataset |
…ab#1987) * replace defaultformatbundle3d with pack3ddetinputs * remove normalize, pad, imagetotensor from configs * rm unused key 'img_norm_cfg' * fix lint errors * fix lint errors * fix lint error * xx
* refine doc * refine docs * replace `CLASSES` with `classes` * update doc * Minor fix Co-authored-by: Tai-Wang <tab_wang@outlook.com>
Xiangxu-0103
changed the title
gt_bboxes_3d for mono_det task in KITTI datasetbbox_3d info in cam_instances for mono3d-det task
… dataset. (open-mmlab#1942) * modify sample_id to sample_id and support fov_image_based on waymo dataset * Update waymo_metric.py * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fix * Minor fixes * Minor fixes * Remove optional * fix dataset instances converting bugs * Add a blank line to fix the doc compilation format * Fix the bin file name in waymo_fov config * Resolve conflicts * fix ci and other things Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: lianqing11 <lianqing11@foxmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn>
Co-authored-by: Tai-Wang <tab_wang@outlook.com>
…mlab#1984) * support fcaf3d for s3dis dataset * Update convert_utils.py * Update seg3d_dataset.py * Delete compose.py * fix import error * use `mmengine.Compose` * Update s3dis-3d.py * Update fcaf3d_2xb8_s3dis-3d-5class.py * Update s3dis_dataset.py * update unittest for s3dis * update docs * use `mmcv.Compose` instead of `mmengine.Compose` * update docstring * fix s3dis preprocessing bug * Add typehint * Update config and fix s3dis dataset * update typehit * Update convert_utils.py * Update README and metafile Co-authored-by: Tai-Wang <tab_wang@outlook.com>
ZCMax
reviewed
Nov 24, 2022
ZCMax
approved these changes
Nov 25, 2022
Tai-Wang
reviewed
Nov 29, 2022
| gt_bboxes_3d = CameraInstance3DBoxes( | ||
| ann_info['gt_bboxes_3d']).convert_to(self.box_mode_3d, | ||
| np.linalg.inv(lidar2cam)) | ||
| # in waymo, lidar2cam = R0_rect @ Tr_velo_to_cam |
There was a problem hiding this comment.
The behaviors should not be the same?
There was a problem hiding this comment.
After updating the converter script, gt_bboxes_3d in cam_instances for WaymoDataset and KittiDataset will be transformed from gravity_center to bottom_center.
ZwwWayne
reviewed
Dec 2, 2022
ZwwWayne
reviewed
Dec 2, 2022
ZwwWayne
force-pushed
the
dev-1.x
branch
2 times, most recently
from
72b8e9f
to
28fe73d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist