Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix missing parameter in Det3DVisualizationHook #2118

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

shanmo
Copy link
Contributor

@shanmo shanmo commented Dec 8, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix #2112

Modification

Add visualization task parameter in the hook

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@shanmo shanmo changed the title Shanmo patch 1 [Fix] fix bug in visualization hook Dec 8, 2022
@shanmo shanmo changed the title [Fix] fix bug in visualization hook [Fix] Fix missing parameter in Det3DVisualizationHook Dec 8, 2022
tools/test.py Show resolved Hide resolved
@ZwwWayne ZwwWayne changed the base branch from 1.1 to dev-1.x December 9, 2022 07:41
@CLAassistant
Copy link

CLAassistant commented Dec 11, 2022

CLA assistant check
All committers have signed the CLA.

@ZwwWayne ZwwWayne merged commit ef6e0aa into open-mmlab:dev-1.x Dec 19, 2022
@shanmo shanmo deleted the shanmo-patch-1 branch December 19, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants