Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #43 Support PETR in 1.1 in projects #2175

Merged
merged 33 commits into from
Jan 5, 2023

Conversation

SekiroRong
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZCMax ZCMax requested a review from ZwwWayne December 30, 2022 04:38
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 45.23% // Head: 45.23% // No change to project coverage 👍

Coverage data is based on head (f0af246) compared to base (edc468b).
Patch has no changes to coverable lines.

❗ Current head f0af246 differs from pull request most recent head 7ee9757. Consider uploading reports for the commit 7ee9757 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2175   +/-   ##
========================================
  Coverage    45.23%   45.23%           
========================================
  Files          253      253           
  Lines        20729    20729           
  Branches      3275     3275           
========================================
  Hits          9377     9377           
  Misses       10733    10733           
  Partials       619      619           
Flag Coverage Δ
unittests 45.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ZwwWayne ZwwWayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need more folders, all files can be put in one folder, so that we can remove these unnecessary init.py files.

petr Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 952a592 into open-mmlab:dev-1.x Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants