Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add task_modules type hint #2485

Merged
merged 18 commits into from
May 25, 2023
Merged

Conversation

A-new-b
Copy link
Contributor

@A-new-b A-new-b commented Apr 27, 2023

Motivation

Add task_modules type hint to the code and make it more readable.

Modification

add type hints to mmdet3d/model/task_modules

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (6299a1f) 46.92% compared to head (9365e9b) 47.02%.

❗ Current head 9365e9b differs from pull request most recent head 8617a01. Consider uploading reports for the commit 8617a01 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2485      +/-   ##
===========================================
+ Coverage    46.92%   47.02%   +0.10%     
===========================================
  Files          277      277              
  Lines        23235    23280      +45     
  Branches      3622     3622              
===========================================
+ Hits         10903    10948      +45     
  Misses       11641    11641              
  Partials       691      691              
Flag Coverage Δ
unittests 47.02% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...det3d/models/task_modules/samplers/pseudosample.py 90.47% <ø> (ø)
.../models/task_modules/anchor/anchor_3d_generator.py 94.40% <100.00%> (+0.16%) ⬆️
mmdet3d/models/task_modules/anchor/builder.py 66.66% <100.00%> (+6.66%) ⬆️
...dels/task_modules/assigners/max_3d_iou_assigner.py 52.08% <100.00%> (ø)
mmdet3d/models/task_modules/builder.py 75.00% <100.00%> (+3.57%) ⬆️
...dels/task_modules/coders/anchor_free_bbox_coder.py 91.07% <100.00%> (+0.50%) ⬆️
...els/task_modules/coders/centerpoint_bbox_coders.py 84.61% <100.00%> (+0.34%) ⬆️
...ls/task_modules/coders/delta_xyzwhlr_bbox_coder.py 86.27% <100.00%> (+0.85%) ⬆️
...3d/models/task_modules/coders/fcos3d_bbox_coder.py 94.33% <100.00%> (+0.33%) ⬆️
...dels/task_modules/coders/groupfree3d_bbox_coder.py 20.00% <100.00%> (+3.33%) ⬆️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12
Copy link
Contributor

Thanks for your PR. Please review this PR. @Xiangxu-0103

A-new-b and others added 13 commits May 18, 2023 16:25
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
@Xiangxu-0103
Copy link
Collaborator

Hi @A-new-b , please update this PR according to the comments and fix the lint issue.

@A-new-b
Copy link
Contributor Author

A-new-b commented May 19, 2023

Hi @A-new-b , please update this PR according to the comments and fix the lint issue.

thanks for your reminder, I have fixed the lint

@JingweiZhang12 JingweiZhang12 merged commit b5a706d into open-mmlab:dev-1.x May 25, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants