Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] change data load function. #2585

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

col14m
Copy link
Contributor

@col14m col14m commented Jun 2, 2023

Changed data load function. Dataset parsing has been accelerated from about 5 hours to 10 minutes.

Motivation

Very slow dataset parsing. The proposed changes speed up parsing from about 5 hours to 10 minutes.

Modification

Only two lines.

Changed data load function. Dataset parsing was accelerated from about 5 hours to 10 minutes.
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2023

CLA assistant check
All committers have signed the CLA.

@col14m col14m changed the title Update indoor3d_util.py [FIX]: Change data load function. Jun 2, 2023
@col14m col14m changed the title [FIX]: Change data load function. [FIX] change data load function. Jun 2, 2023
@col14m
Copy link
Contributor Author

col14m commented Jun 2, 2023

Don't quite understand lint problem.

@Xiangxu-0103 Xiangxu-0103 changed the base branch from main to dev-1.x June 2, 2023 14:13
@Xiangxu-0103
Copy link
Collaborator

Please fix lint following this guidance.

@col14m
Copy link
Contributor Author

col14m commented Jun 3, 2023

I had run pre-commit and got something strange (see the screen). Is it normal?
photo_2023-06-03_11-22-20

@JingweiZhang12
Copy link
Contributor

@col14m Thanks for your code for speeding up parsing. Cool! The lint problem is our negligence about another PR check. I have updated this PR.

@JingweiZhang12 JingweiZhang12 merged commit e753ecb into open-mmlab:dev-1.x Jun 6, 2023
9 checks passed
@OpenMMLab-Assistant-004
Copy link

Hi @col14m,

We'd like to express our appreciation for your valuable contributions to the mmdetection3d. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants