Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] modify download script for nuscenes #2660

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jul 20, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

unzip cannot unpack tgz file.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f9dfa9) 46.78% compared to head (469629e) 46.78%.

❗ Current head 469629e differs from pull request most recent head b4cd6ba. Consider uploading reports for the commit b4cd6ba to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2660   +/-   ##
========================================
  Coverage    46.78%   46.78%           
========================================
  Files          277      277           
  Lines        23480    23480           
  Branches      3660     3660           
========================================
  Hits         10984    10984           
  Misses       11802    11802           
  Partials       694      694           
Flag Coverage Δ
unittests 46.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit e03bc46 into open-mmlab:dev-1.x Aug 1, 2023
13 of 15 checks passed
@wep21 wep21 deleted the fix/download-nusc branch August 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants