Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #2895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/scannet/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ We follow the procedure in [votenet](https://github.com/facebookresearch/votenet
4. Enter the project root directory, generate training data by running

```bash
python tools/create_data.py scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet
python tools/create_data.py --dataset scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we do not need to add --dataset argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how you run this script, but on my end, when I run the script without the --dataset argument ( for scannet for example), I get the following error:

usage: create_data.py [-h] [--dataset kitti] [--root-path ROOT_PATH] [--version VERSION] [--max-sweeps MAX_SWEEPS] --out-dir OUT_DIR [--extra-tag EXTRA_TAG]
                      [--workers WORKERS]
create_data.py: error: unrecognized arguments: scannet

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line makes the script expecting the --dataset argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using python 3.10 btw.

```

The overall process could be achieved through the following script
Expand Down