Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Chinese Document of faq #730

Merged
merged 4 commits into from
Jul 21, 2021
Merged

[Docs] Chinese Document of faq #730

merged 4 commits into from
Jul 21, 2021

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Jul 12, 2021

  • Add Chinese Document of faq
  • Refine a typo in faq

@wHao-Wu wHao-Wu requested a review from xiliu8006 July 12, 2021 12:42
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #730 (615cb1e) into master (2f95eb7) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   48.91%   48.96%   +0.04%     
==========================================
  Files         208      208              
  Lines       15866    15880      +14     
  Branches     2546     2538       -8     
==========================================
+ Hits         7761     7775      +14     
+ Misses       7609     7603       -6     
- Partials      496      502       +6     
Flag Coverage Δ
unittests 48.96% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/detectors/single_stage.py 58.62% <0.00%> (-17.57%) ⬇️
mmdet3d/datasets/scannet_dataset.py 78.51% <0.00%> (-9.34%) ⬇️
mmdet3d/models/detectors/imvotenet.py 26.66% <0.00%> (ø)
mmdet3d/models/dense_heads/fcos_mono3d_head.py 12.10% <0.00%> (+0.13%) ⬆️
...et3d/models/dense_heads/anchor_free_mono3d_head.py 65.31% <0.00%> (+6.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f95eb7...615cb1e. Read the comment docs.

@ZwwWayne ZwwWayne mentioned this pull request Jul 13, 2021
14 tasks

``TypeError: expected dtype object, got 'numpy.dtype[bool_]'``

请将 numpy 的版本降级至 < 1.20.0,或者从源码安装 numba == 0.48,这是由于 numpy == 1.20.0 改变了 API,使得在调用 `np.dtype` 会产生子类。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiliu8006
I'm not sure whether the Chinese meaning is suitable for explaining the problem in the English document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change the '使得在调用 np.dtype 会产生子类' to "more details on this issue", Change it on English version please

@yezhen17 yezhen17 self-requested a review July 14, 2021 10:15
docs_zh-CN/faq.md Outdated Show resolved Hide resolved
@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Jul 21, 2021

@Tai-Wang
Comments resolved.

@ZwwWayne ZwwWayne merged commit 26c1807 into open-mmlab:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants