Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add kitti AP40 evaluation metric #914

Closed
wants to merge 5 commits into from

Conversation

ZCMax
Copy link
Collaborator

@ZCMax ZCMax commented Sep 6, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #914 (7156b85) into master (075f444) will decrease coverage by 0.17%.
The diff coverage is 1.92%.

❗ Current head 7156b85 differs from pull request most recent head d66bffd. Consider uploading reports for the commit d66bffd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   49.33%   49.15%   -0.18%     
==========================================
  Files         210      210              
  Lines       16021    16081      +60     
  Branches     2556     2577      +21     
==========================================
+ Hits         7904     7905       +1     
- Misses       7614     7673      +59     
  Partials      503      503              
Flag Coverage Δ
unittests 49.15% <1.92%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/evaluation/kitti_utils/eval.py 29.04% <1.92%> (-3.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075f444...d66bffd. Read the comment docs.

@ZCMax ZCMax requested a review from Tai-Wang September 6, 2021 08:57
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rollback the changed variable names

@ZwwWayne ZwwWayne closed this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants