Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: fix multi-batch test problem #95

Merged
merged 11 commits into from
Sep 11, 2020

Conversation

xavierwu95
Copy link
Contributor

@xavierwu95 xavierwu95 commented Sep 8, 2020

1.Fix #89
2. fix unittest bug in test_part_aggregation_ROI_head.

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2020

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Sep 8, 2020

Make the unit test data tests/test_samples/parta2_roihead_inputs.npz smaller than 100KB to reduce the burden of downloading/cloning the repo.

Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing maybe needed to be improve is the size of .npz file. Saving it as .bin file or using other data type (like reduce float32 to float16) may help?

@xavierwu95 xavierwu95 changed the title Support multibatch test [Fix]: fix multi-batch test problem Sep 11, 2020
@ZwwWayne ZwwWayne merged commit e485721 into open-mmlab:master Sep 11, 2020
@ZwwWayne ZwwWayne mentioned this pull request Sep 20, 2020
7 tasks
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* align mmedit static cfg

* add docstring for mmcls

* update

* update for mmdet

* update for mmseg

* update for mmocr

* resolve comments

* add doc for mmedit

* add docstring for mmcls

* update

* update for mmdet

* update for mmseg

* update for mmocr

* add doc for mmedit

* resolve comments

* resolve comments

* add type hint

* resolve comments

* resolve comments

Co-authored-by: SingleZombie <singlezombie@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if isinstance(result[0], tuple): KeyError: 0
4 participants