Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_unused_parameters in PyTorch 1.8 for BasicVSR #290

Merged
merged 1 commit into from
May 24, 2021

Conversation

ckkelvinchan
Copy link
Member

As discussed in #273, training of BasicVSR halted due to the settings of find_unused_parameters. This PR fixes the error in PyTorch1.8 by removing the modification of find_unused_parameters during training. find_unused_parameters is kept True throughout training.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #290 (f34b49d) into master (3cfdd8f) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   80.54%   80.54%   -0.01%     
==========================================
  Files         162      162              
  Lines        8091     8090       -1     
  Branches     1192     1192              
==========================================
- Hits         6517     6516       -1     
  Misses       1429     1429              
  Partials      145      145              
Flag Coverage Δ
unittests 80.54% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/restorers/basicvsr.py 68.88% <66.66%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfdd8f...f34b49d. Read the comment docs.

@innerlee innerlee requested a review from nbei May 13, 2021 04:25
@innerlee
Copy link
Contributor

@nbei please confirm that the changes is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants