[Feature] Support different filename templates in GenerateSegmentIndices #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerlee
reviewed
May 24, 2021
innerlee
reviewed
May 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 80.84% 80.92% +0.07%
==========================================
Files 166 168 +2
Lines 8359 8409 +50
Branches 1205 1216 +11
==========================================
+ Hits 6758 6805 +47
- Misses 1453 1454 +1
- Partials 148 150 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
May 24, 2021
| @@ -27,15 +27,18 @@ def restoration_video_inference(model, img_dir, window_size): | |||
| window_size (int): The window size used in sliding-window framework. | |||
| This value should be set according to the settings of the network. | |||
| A value smaller than 0 means using recurrent framework. | |||
|
|
|||
innerlee
reviewed
May 24, 2021
| @@ -964,11 +966,13 @@ def __call__(self, results): | |||
| lq_path_root = results['lq_path'] | |||
| gt_path_root = results['gt_path'] | |||
| lq_path = [ | |||
| osp.join(lq_path_root, clip_name, f'{v:08d}.png') | |||
| osp.join(lq_path_root, clip_name, | |||
| f'{self.filename_tmpl.format(v)}.png') | |||
There was a problem hiding this comment.
Question: should .png be part of the template?
There was a problem hiding this comment.
We usually use .png, but I think that could work if someone wants to use jpg as inputs. I will modify that.
innerlee
reviewed
May 24, 2021
| osp.join(lq_path_root, clip_name, f'{v:08d}.png') | ||
| for v in neighbor_list | ||
| osp.join(lq_path_root, clip_name, | ||
| f'{self.filename_tmpl.format(v)}') for v in neighbor_list |
There was a problem hiding this comment.
In this case, the f-str is redundant
There was a problem hiding this comment.
Oh you are right. I missed that.
innerlee
approved these changes
May 24, 2021
Yshuo-Li
pushed a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
…ces (open-mmlab#325) * Add message. * Use os.path.isfile * Support different filename template in GenerateSegmentIndices * Add space line * Move .png into the filename_tmpl * Remove f-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in issue #323, there will be errors if the file names are not formated as
{v:08d}.png. This may cause problems if one use custom filename format.Modification
In this PR, we modify
GenerateSegmentIndicesso that one can use different filename formats. But note that the frame indices must start from 0.