Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add SRFolderVideoDataset #370

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Conversation

ckkelvinchan
Copy link
Member

This is a follow-up to #355. This PR adds support to training on arbitrary datasets for sliding-window methods, such as EDVR and TDAN.

@innerlee innerlee requested a review from Yshuo-Li June 15, 2021 06:46
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #370 (2a76ab3) into master (2c21fa8) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 2a76ab3 differs from pull request most recent head 5816f13. Consider uploading reports for the commit 5816f13 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   80.30%   80.24%   -0.07%     
==========================================
  Files         184      185       +1     
  Lines        9831     9811      -20     
  Branches     1427     1441      +14     
==========================================
- Hits         7895     7873      -22     
- Misses       1743     1744       +1     
- Partials      193      194       +1     
Flag Coverage Δ
unittests 80.24% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/sr_folder_multiple_gt_dataset.py 100.00% <ø> (ø)
mmedit/datasets/__init__.py 100.00% <100.00%> (ø)
mmedit/datasets/pipelines/augmentation.py 96.97% <100.00%> (-0.09%) ⬇️
mmedit/datasets/sr_folder_video_dataset.py 100.00% <100.00%> (ø)
...ackbones/encoder_decoders/pconv_encoder_decoder.py 43.47% <0.00%> (-2.36%) ⬇️
mmedit/models/base.py 82.75% <0.00%> (-2.09%) ⬇️
...ones/encoder_decoders/two_stage_encoder_decoder.py 53.84% <0.00%> (-1.16%) ⬇️
...dels/backbones/encoder_decoders/encoders/resnet.py 66.01% <0.00%> (-0.97%) ⬇️
...s/backbones/encoder_decoders/gl_encoder_decoder.py 81.48% <0.00%> (-0.67%) ⬇️
mmedit/datasets/pipelines/normalization.py 88.88% <0.00%> (-0.59%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c21fa8...5816f13. Read the comment docs.

@innerlee
Copy link
Contributor

Need rebase

… sliding

Conflicts:
	mmedit/datasets/__init__.py
@innerlee innerlee merged commit 09cbdf2 into open-mmlab:master Jun 17, 2021
@ckkelvinchan ckkelvinchan deleted the sliding branch July 8, 2021 03:12
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* Add SRFolderVideoDataset

* Minor fix

* Fix bug of max_frame_num
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants