Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support crop sequence #648

Merged
merged 3 commits into from Dec 19, 2021

Conversation

ckkelvinchan
Copy link
Member

Motivation

Support random cropping a sequence of images. The existing crop function Crop will choose different regions for each image in a sequence.

This PR adds the functionality CropSequence, which crops the same region for every image in the sequence.

Modification

Modify crop.py

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #648 (2768b04) into master (d8c7780) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   80.61%   80.65%   +0.03%     
==========================================
  Files         199      199              
  Lines       11351    11371      +20     
  Branches     1814     1818       +4     
==========================================
+ Hits         9151     9171      +20     
  Misses       1916     1916              
  Partials      284      284              
Flag Coverage Δ
unittests 80.63% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmedit/datasets/pipelines/crop.py 97.24% <100.00%> (+0.20%) ⬆️
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️
mmedit/datasets/pipelines/blur_kernels.py 84.55% <0.00%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c7780...2768b04. Read the comment docs.

@nbei
Copy link
Collaborator

nbei commented Dec 19, 2021

You may fix the conflicts.

… crop-sequence

Conflicts:
	mmedit/datasets/pipelines/__init__.py
@ckkelvinchan ckkelvinchan merged commit 9e7d78f into open-mmlab:master Dec 19, 2021
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants