[CI] Update Pillow from 6.2.2 to 8.4 in CI #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangruohui
changed the title
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=======================================
Coverage 80.61% 80.61%
=======================================
Files 200 200
Lines 11419 11419
Branches 1831 1831
=======================================
Hits 9205 9205
Misses 1931 1931
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ckkelvinchan
approved these changes
Jan 5, 2022
Yshuo-Li
pushed a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
Yshuo-Li
pushed a commit
to Yshuo-Li/mmediting
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve: https://github.com/open-mmlab/mmediting/runs/4697550155?check_suite_focus=true#step:12:109
In the previous GitHub workflow, installation of Pillow==6.2.2 is useless because it will be overwritten afterward in
pip install -r requirements.txt. The actual version installed finally is 8.4.0. This version is compatible with old torchvision becausePILLOW_VERSIONis re-imported (which is removed in version 7), so previous CI works until 2022-Jan-02 when Pillow 9 was released. So I tried to use Pillow<9 to keep this compatibility with old-versioned torchvision as well as other dependencies.