Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support DCN on CPU #735

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Conversation

ckkelvinchan
Copy link
Member

Motivation

Since mmcv supports DCN on CPU, we can now support DCN in EDVR and BasicVSR++

Modification

Modify the following files:

  1. mmedit/models/backbones/sr_backbones/basicvsr_pp.py
  2. tests/test_models/test_backbones/test_sr_backbones/test_basicvsr_plusplus.py
  3. tests/test_models/test_backbones/test_sr_backbones/test_edvr_net.py

Note

@wangruohui there seems to be a problem in pre-commit hook. I need to modify .pre-commit-config.yaml to use pre-commit hook. Could you help have a look?

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #735 (17e75f5) into master (7245818) will increase coverage by 0.75%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   82.18%   82.93%   +0.75%     
==========================================
  Files         215      215              
  Lines       12125    12121       -4     
  Branches     1946     1945       -1     
==========================================
+ Hits         9965    10053      +88     
+ Misses       1853     1763      -90     
+ Partials      307      305       -2     
Flag Coverage Δ
unittests 82.92% <60.00%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...medit/models/backbones/sr_backbones/basicvsr_pp.py 76.08% <60.00%> (+15.98%) ⬆️
mmedit/models/backbones/sr_backbones/edvr_net.py 98.36% <0.00%> (+33.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b091329...17e75f5. Read the comment docs.

@wangruohui wangruohui merged commit 43fc572 into open-mmlab:master Feb 11, 2022
@wangruohui
Copy link
Member

Close #730

Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* support dcn on cpu

* revert pre-commit config
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* support dcn on cpu

* revert pre-commit config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants