Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a config of TOFlow #811

Merged
merged 8 commits into from
Apr 1, 2022
Merged

Conversation

Yshuo-Li
Copy link
Collaborator

No description provided.

@mm-assistant mm-assistant bot added the size/XS label Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #811 (052253c) into master (c2ad4f7) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   83.04%   83.08%   +0.03%     
==========================================
  Files         216      219       +3     
  Lines       12239    12354     +115     
  Branches     1975     2000      +25     
==========================================
+ Hits        10164    10264     +100     
- Misses       1767     1774       +7     
- Partials      308      316       +8     
Flag Coverage Δ
unittests 83.04% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/losses/perceptual_loss.py 91.58% <0.00%> (-4.38%) ⬇️
mmedit/models/losses/gan_loss.py 96.80% <0.00%> (-3.21%) ⬇️
mmedit/datasets/builder.py 93.22% <0.00%> (-1.61%) ⬇️
mmedit/core/evaluation/metrics.py 96.78% <0.00%> (-0.90%) ⬇️
mmedit/utils/__init__.py 100.00% <0.00%> (ø)
mmedit/datasets/pipelines/augmentation.py 98.49% <0.00%> (ø)
mmedit/core/utils/dist_utils.py 56.25% <0.00%> (ø)
mmedit/core/utils/__init__.py 100.00% <0.00%> (ø)
mmedit/utils/cli.py 90.90% <0.00%> (ø)
mmedit/datasets/pipelines/blur_kernels.py 84.55% <0.00%> (+1.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ad4f7...052253c. Read the comment docs.

]
metrics[key] = dict(
PSNR=metrics_data[0], SSIM=metrics_data[1])
except ValueError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will trigger a ValueError?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supplementary information for the model, such as Pretrained SPyNet in TOFlow.

# train
train=dict(
type='RepeatDataset',
times=1000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why repeat 1000 times, instead of let IterBasedRunner iter over it internally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a safer approach.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangruohui When "reloading" the dataset, it consumes additional time.

root_dir = 'data/vimeo_triplet'
data = dict(
workers_per_gpu=1,
train_dataloader=dict(samples_per_gpu=1, drop_last=True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many GPUs by default does this config run on?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One GPU is enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 GPU with batch size 1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

interval=100, hooks=[
dict(type='TextLoggerHook', by_epoch=False),
])
visual_config = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this config for?

@wangruohui wangruohui merged commit 3300f27 into open-mmlab:master Apr 1, 2022
@Yshuo-Li Yshuo-Li deleted the c1 branch April 7, 2022 07:40
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Add config of TOFlow

* Update

* Update

* Update

* Update

* Update

* Update

* Update
Yshuo-Li added a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
* [Feature] Add config of TOFlow

* Update

* Update

* Update

* Update

* Update

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants