Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Translate data_element.md #1067

Merged
merged 17 commits into from May 23, 2023

Conversation

xin-li-67
Copy link
Contributor

Motivation

MMSIG task: translate data_element.md

Modification

docs/en/advanced_tutorials/data_element.md
docs/zh_cn/advanced_tutorials/data_element.md

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@xin-li-67 xin-li-67 requested a review from C1rN09 as a code owner April 11, 2023 04:45
@xin-li-67 xin-li-67 changed the title Translate data_element.md [MMSIG-66] Translate data_element.md Apr 20, 2023
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
xin-li-67 and others added 6 commits April 23, 2023 13:28
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
MMEngine extended `InstanceData` based on the above assumption, including:

- length checking of the data store in `InstanceData`
- supports dictionary-like access and setting of its properties
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts with the description here. Maybe we need to check the correctness of the Chinese docs.

docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
xin-li-67 and others added 3 commits April 27, 2023 09:50
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
@HAOCHENYE
Copy link
Collaborator

Hi, please resolve the conflicts

HAOCHENYE
HAOCHENYE previously approved these changes May 6, 2023
docs/zh_cn/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
HAOCHENYE
HAOCHENYE previously approved these changes May 12, 2023
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
docs/en/advanced_tutorials/data_element.md Outdated Show resolved Hide resolved
zhouzaida
zhouzaida previously approved these changes May 23, 2023
@zhouzaida zhouzaida changed the title [MMSIG-66] Translate data_element.md [Docs] Translate data_element.md May 23, 2023
@zhouzaida zhouzaida merged commit d59acfb into open-mmlab:main May 23, 2023
8 checks passed
@xin-li-67 xin-li-67 deleted the data_element_translate branch May 23, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants